feat: support literal for ARRAY top level #1978
Conversation
| @@ -472,5 +475,4 @@ message DataType { | |||
| } | |||
|
|
|||
| DataTypeInfo type_info = 2; | |||
There was a problem hiding this comment.
I'm preferring to move all DataType proto message into types.proto
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
============================================
+ Coverage 56.12% 56.62% +0.49%
- Complexity 976 1193 +217
============================================
Files 119 135 +16
Lines 11743 13209 +1466
Branches 2251 2416 +165
============================================
+ Hits 6591 7479 +888
- Misses 4012 4507 +495
- Partials 1140 1223 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Per the spark documentation these are the literals aupported by Spark - https://spark.apache.org/docs/latest/sql-ref-literals.html |
Thanks @parthchandra |
| .build_list_scalar() | ||
| } | ||
| DataType::Boolean => { | ||
| let vals = values.clone(); |
There was a problem hiding this comment.
I'll create a macro in followup PR to remove repeated code
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| // Include generated modules from .proto files. | |||
| #[allow(missing_docs)] | |||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
clippy complains on proto enums
| if supportedDataType( | ||
| dataType, | ||
| allowComplex = value == null || Seq( | ||
| CometConf.SCAN_NATIVE_ICEBERG_COMPAT, |
There was a problem hiding this comment.
should we also support AUTO?
|
Depends on |
Which issue does this PR close?
Closes #1977 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?